Enhanced Ingestion with Named Graph Restrictions #19
Conversation
…sage from the publisher.
| ): | ||
| if not files: | ||
| raise HTTPException(status_code=400, detail="No files provided") | ||
| named_graph_iri = named_graph_exists(graph) | ||
| if named_graph_iri["status"] != True: |
There was a problem hiding this comment.
What does this mean if the status is not True? Should the HTTP response back not be a 200?
| @@ -378,7 +414,8 @@ async def ingest_knowledge_graphs_batch( | |||
|
|
|||
|
|
|||
| @router.post("/upload/document", summary="Ingest a either TXT, JSON and PDF files", | |||
| dependencies=[Depends(require_scopes(["write"]))] | |||
| dependencies=[Depends(require_scopes(["write"]))], | |||
There was a problem hiding this comment.
Do you also want to include the LoggedIn annotation kwarg that you've been including elsewhere?
There was a problem hiding this comment.
yes, I want to include it.
| "user": posting_user, | ||
| "filename": file.filename, | ||
| "extension": file.filename.split('.')[-1].lower() | ||
| }) | ||
|
|
||
|
|
||
|
|
||
| @router.post("/upload/documents", |
There was a problem hiding this comment.
| } | ||
|
|
||
| try: | ||
| response = requests.get(endpoint) |
There was a problem hiding this comment.
requests is a synchronous call -- is this function eventually being called in an upstream async call?
| return { | ||
| "status": "error", | ||
| "message": f"Error connecting to query service: {str(e)}" | ||
| } |
There was a problem hiding this comment.
Should this have an HTTP status code indicating it is an error returned as well?
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| async def background_task(): |
There was a problem hiding this comment.
Should this also be apart of the @app.on_event("startup")?
| - RABBITMQ_URL, i.e., the hostname, by default it is localhost | ||
| - RABBITMQ_PORT, by default 5672 is used | ||
| - RABBITMQ_VHOST, default vhost is "/" | ||
| - |
There was a problem hiding this comment.
Did you mean to add something here regarding the ingestion URL?
…mq + prometheus + grafana
…ther than json string
Enhanced Ingestion with Named Graph Restrictions
Features Implemented